Add missing xml namespace declarations to POM files #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without these declarations, the XML file cannot be validated correctly. See examples: * <https://maven.apache.org/pom.html#Quick_Overview> * <https://github.com/aws/aws-sdk-java-v2/blob/master/aws-sdk-java/pom.xml> The tool I'm using actually tries to validate these before using them (<https://tiny.amazon.com/ibdzmlln/paste> -- Amazon internal link), so that's why I ran into issues. I'm assuming most tools don't have the validation enabled, so this is why others haven't reported this before. The same issue can be easily replicated by pasting the current POM files in <https://www.w3schools.com/xml/xml_validator.asp> as well as just trying to open them with Firefox. (P.s: Hello there Lambda team! We recently met in your Dublin office!)
bmoffatt
approved these changes
Sep 2, 2019
raupachz
pushed a commit
to raupachz/aws-lambda-java-libs
that referenced
this pull request
Dec 1, 2020
Without these declarations, the XML file cannot be validated correctly. See examples: * <https://maven.apache.org/pom.html#Quick_Overview> * <https://github.com/aws/aws-sdk-java-v2/blob/master/aws-sdk-java/pom.xml> The tool I'm using actually tries to validate these before using them (<https://tiny.amazon.com/ibdzmlln/paste> -- Amazon internal link), so that's why I ran into issues. I'm assuming most tools don't have the validation enabled, so this is why others haven't reported this before. The same issue can be easily replicated by pasting the current POM files in <https://www.w3schools.com/xml/xml_validator.asp> as well as just trying to open them with Firefox. (P.s: Hello there Lambda team! We recently met in your Dublin office!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without these declarations, the XML file cannot be validated correctly.
See examples:
The tool I'm using actually tries to validate these before using them
(https://tiny.amazon.com/ibdzmlln/paste -- Amazon internal link), so
that's why I ran into issues. I'm assuming most tools don't have the
validation enabled, so this is why others haven't reported this before.
The same issue can be easily replicated by pasting the current POM
files in https://www.w3schools.com/xml/xml_validator.asp as well
as just trying to open them with Firefox.
(P.s: Hello there Lambda team! We recently met in your Dublin office!)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.